Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: tracing/tracing/ui/base/table.html

Issue 2390373003: Change all == to === and != to !== in trace viewer. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/base/table.html
diff --git a/tracing/tracing/ui/base/table.html b/tracing/tracing/ui/base/table.html
index f906429320940bac9b5d7797d76f6efbe8612d3a..548c4f11a7c7a9c6593b02942289d46b9addd024 100644
--- a/tracing/tracing/ui/base/table.html
+++ b/tracing/tracing/ui/base/table.html
@@ -715,7 +715,7 @@ tr.exportTo('tr.ui.b', function() {
if (this.doesColumnIndexSupportSelection(i))
Polymer.dom(td).classList.add('supports-selection');
- if (this.columnsWithExpandButtons_.indexOf(i) != -1) {
+ if (this.columnsWithExpandButtons_.indexOf(i) !== -1) {
if (rowInfo.userRow[this.subRowsPropertyName_] &&
rowInfo.userRow[this.subRowsPropertyName_].length > 0) {
td.style.paddingLeft = INDENT_SPACE + 'px';
@@ -918,7 +918,8 @@ tr.exportTo('tr.ui.b', function() {
return false;
if (userRow.isExpanded)
return true;
- if (userRow.isExpanded === false)
+ if ((userRow.isExpanded !== undefined) &&
+ (userRow.isExpanded === false))
charliea (OOO until 10-5) 2016/10/05 18:53:42 Did you mean to make this change? Looks like we ma
return false;
var rowInfo = this.tableRowsInfo_.get(userRow);

Powered by Google App Engine
This is Rietveld 408576698