Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch
we used the regular css style property parsing routines which
are different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
Committed: https://crrev.com/03ea643145f194a757feeb7ced2240c2d2c8f5dc
Cr-Commit-Position: refs/heads/master@{#423177}

[rwlbuis, 2016-10-04 19:45:01]

Description was changed from

==========
652362 WIP

BUG=
==========

to

==========
652362 WIP

BUG=652362
==========

[rwlbuis, 2016-10-04 19:50:25]

Description was changed from

==========
652362 WIP

BUG=652362
==========

to

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch we
used the regular css style property parsing routines which are
different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse @font-face
descriptors.

BUG=652362
==========

[rwlbuis, 2016-10-04 19:50:43]

Description was changed from

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch we
used the regular css style property parsing routines which are
different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse @font-face
descriptors.

BUG=652362
==========

to

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch we
used the regular css style property parsing routines which are
different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
==========

[rwlbuis, 2016-10-04 19:51:28]

Description was changed from

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch we
used the regular css style property parsing routines which are
different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
==========

to

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch
we used the regular css style property parsing routines which
are different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
==========

[rwlbuis, 2016-10-04 21:09:21]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-10-04 21:09:21]

PTAL.

[Timothy Loh, 2016-10-05 03:08:54]

lgtm

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/StylePropertySet.h (right):

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/StylePropertySet.h:208: CSSParserMode =
HTMLStandardMode);
Doesn't look like any of these changes are needed.

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSParserMode.h (right):

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSParserMode.h:51: // @viewport rules
are parsed in standards mode but CSSOM modifications (via StylePropertySet)
Comment needs to be updated, maybe something like

// @viewport/@font-face rules are specially tagged in StylePropertySet so CSSOM
modifications don't treat them as style rules.

[rwlbuis, 2016-10-05 14:21:37]

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/StylePropertySet.h (right):

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/StylePropertySet.h:208: CSSParserMode =
HTMLStandardMode);
On 2016/10/05 03:08:54, Timothy Loh wrote:
> Doesn't look like any of these changes are needed.

Well spotted, I think I was trying multiple approaches and forgot to remove.

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSParserMode.h (right):

https://codereview.chromium.org/2390373002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSParserMode.h:51: // @viewport rules
are parsed in standards mode but CSSOM modifications (via StylePropertySet)
On 2016/10/05 03:08:54, Timothy Loh wrote:
> Comment needs to be updated, maybe something like
> 
> // @viewport/@font-face rules are specially tagged in StylePropertySet so
CSSOM
> modifications don't treat them as style rules.

Done.

[rwlbuis, 2016-10-05 14:21:43]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-10-05 14:21:44]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2390373002/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-10-05 14:22:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 16:17:06]

Description was changed from

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch
we used the regular css style property parsing routines which
are different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
==========

to

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch
we used the regular css style property parsing routines which
are different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
==========

[commit-bot: I haz the power, 2016-10-05 16:17:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 16:19:19]

Description was changed from

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch
we used the regular css style property parsing routines which
are different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362
==========

to

==========
Fix setting properties on CSSFontFaceRule

Fix setting properties on CSSFontFaceRule, before this patch
we used the regular css style property parsing routines which
are different from the @font-face specific descriptor parsing.
So reintroduce a mode to the CSSParserMode enumeration for
font-face rule and use it in order to properly parse
@font-face descriptors.

BUG=652362

Committed: https://crrev.com/03ea643145f194a757feeb7ced2240c2d2c8f5dc
Cr-Commit-Position: refs/heads/master@{#423177}
==========

[commit-bot: I haz the power, 2016-10-05 16:19:20]

Patchset 2 (id:??) landed as
https://crrev.com/03ea643145f194a757feeb7ced2240c2d2c8f5dc
Cr-Commit-Position: refs/heads/master@{#423177}