Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2390353002: Remove testing early return in RenderFrame::willSendRequest (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove testing early return in RenderFrame::willSendRequest Noticed this while reading some random code. Nothing appears to actually depend on this early return, so just remove it. BUG=none Committed: https://crrev.com/53f2d769c496b7c92cb84df793dcfab95c8fb340 Cr-Commit-Position: refs/heads/master@{#423048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dcheng
4 years, 2 months ago (2016-10-04 19:23:36 UTC) #5
Charlie Reis
LGTM. Happy to see dead code go. (Sanity check: No layout tests depend on it, ...
4 years, 2 months ago (2016-10-04 19:56:04 UTC) #8
dcheng
Locally layout tests look OK. I'll try CQing it and see what happens on the ...
4 years, 2 months ago (2016-10-05 02:01:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390353002/1
4 years, 2 months ago (2016-10-05 02:02:19 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 02:07:35 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 02:09:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53f2d769c496b7c92cb84df793dcfab95c8fb340
Cr-Commit-Position: refs/heads/master@{#423048}

Powered by Google App Engine
This is Rietveld 408576698