Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2390333002: DevTools: fix tabbed editor to not open all bound files (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix tabbed editor to not open all bound files The crrev.com/2384783003 introduced a regression where tabbedEditorContainer starts opening file for every created persistence binding. This patch fixes the issue. BUG=none R=pfeldman, dgozman Committed: https://crrev.com/ee3f3ecc70239d4adfc401f5a9bad703c702881f Cr-Commit-Position: refs/heads/master@{#422881}

Patch Set 1 #

Patch Set 2 : nit #

Messages

Total messages: 10 (5 generated)
lushnikov
please, take a look
4 years, 2 months ago (2016-10-04 17:35:54 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-04 18:46:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390333002/20001
4 years, 2 months ago (2016-10-04 18:47:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 19:14:24 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:18:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee3f3ecc70239d4adfc401f5a9bad703c702881f
Cr-Commit-Position: refs/heads/master@{#422881}

Powered by Google App Engine
This is Rietveld 408576698