Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 2390323003: Document timestamp caveat in FileSystem API move operation. (Closed)

Created:
4 years, 2 months ago by pwnall
Modified:
4 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Document timestamp caveat in FileSystem API move operation. We don't plan to fix the bug, because the FileSystem API is in maintenance mode. We document the bug as a heads-up to anyone (most likely us in the future) who might want to reuse the code. BUG=171284 Committed: https://crrev.com/d4981b1884e71d2d4828ab434f0b8397b9e6a17d Cr-Commit-Position: refs/heads/master@{#423034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M storage/browser/fileapi/file_system_operation.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
pwnall
PTAL? I'm doing this as a part of WontFix-ing http://crbug.com/171284
4 years, 2 months ago (2016-10-04 20:03:41 UTC) #4
michaeln
lgtm
4 years, 2 months ago (2016-10-05 00:54:02 UTC) #7
pwnall
On 2016/10/05 00:54:02, michaeln wrote: > lgtm Thank you very much for the quick turnaround!
4 years, 2 months ago (2016-10-05 01:12:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390323003/1
4 years, 2 months ago (2016-10-05 01:13:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 01:19:17 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d4981b1884e71d2d4828ab434f0b8397b9e6a17d Cr-Commit-Position: refs/heads/master@{#423034}
4 years, 2 months ago (2016-10-05 01:21:25 UTC) #13
michaeln
On 2016/10/05 01:12:55, pwnall wrote: > On 2016/10/05 00:54:02, michaeln wrote: > > lgtm > ...
4 years, 2 months ago (2016-10-05 01:35:23 UTC) #14
pwnall
4 years, 2 months ago (2016-10-05 01:45:44 UTC) #15
Message was sent while issue was closed.
On 2016/10/05 01:35:23, michaeln wrote:
> On 2016/10/05 01:12:55, pwnall wrote:
> > On 2016/10/05 00:54:02, michaeln wrote:
> > > lgtm
> > 
> > Thank you very much for the quick turnaround!
> 
> sry i didn't notice hours earlier :)

Same day is quick in my book :D

Thanks!

Powered by Google App Engine
This is Rietveld 408576698