Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 23903053: reland 16744: add context save for GenerateFastApiCall (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

reland 16744: add context save for GenerateFastApiCall R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -138 lines) Patch
M include/v8.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/arguments.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +31 lines, -15 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 12 chunks +43 lines, -23 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 6 chunks +27 lines, -13 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 11 chunks +41 lines, -25 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +27 lines, -13 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 11 chunks +50 lines, -36 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
okay, here it is with just frame scopes, no register backing up. seems to pass ...
7 years, 3 months ago (2013-09-17 09:16:56 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 3 months ago (2013-09-17 11:35:56 UTC) #2
dcarney
7 years, 3 months ago (2013-09-17 11:38:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698