Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chromeos/cryptohome/cryptohome_library.h

Issue 23903051: Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/renderer_host/pepper/device_id_fetcher.cc ('K') | « chrome/browser/renderer_host/pepper/device_id_fetcher.cc ('k') | chromeos/cryptohome/cryptohome_library.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/cryptohome/cryptohome_library.h
diff --git a/chromeos/cryptohome/cryptohome_library.h b/chromeos/cryptohome/cryptohome_library.h
index 1e3aca9e1f8617c5aad082fd9f8ded144c06cfb5..589addb22b8a649154641a24d310513e8c8961d4 100644
--- a/chromeos/cryptohome/cryptohome_library.h
+++ b/chromeos/cryptohome/cryptohome_library.h
@@ -59,7 +59,9 @@ class CHROMEOS_EXPORT CryptohomeLibrary {
virtual bool InstallAttributesIsInvalid() = 0;
virtual bool InstallAttributesIsFirstInstall() = 0;
- // Returns system hash in hex encoded ascii format.
+ // Returns system hash in hex encoded ascii format. Note: this may return
+ // an empty string (e.g. if cryptohome is not running). It is up to the
+ // calling function to try again after a delay if desired.
virtual std::string GetSystemSalt() = 0;
zel 2013/09/20 16:28:05 this method should obviously be converted to async
// Encrypts |token| with the system salt key (stable for the lifetime
« chrome/browser/renderer_host/pepper/device_id_fetcher.cc ('K') | « chrome/browser/renderer_host/pepper/device_id_fetcher.cc ('k') | chromeos/cryptohome/cryptohome_library.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698