chromeos/cryptohome/cryptohome_library.h - Issue 23903051: Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/cryptohome/cryptohome_library.h

Issue 23903051: Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Access WeakPtr from UI thread only Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/cryptohome/cryptohome_library.h

diff --git a/chromeos/cryptohome/cryptohome_library.h b/chromeos/cryptohome/cryptohome_library.h

index 1e3aca9e1f8617c5aad082fd9f8ded144c06cfb5..589addb22b8a649154641a24d310513e8c8961d4 100644

--- a/chromeos/cryptohome/cryptohome_library.h

+++ b/chromeos/cryptohome/cryptohome_library.h

@@ -59,7 +59,9 @@ class CHROMEOS_EXPORT CryptohomeLibrary {

virtual bool InstallAttributesIsInvalid() = 0;

virtual bool InstallAttributesIsFirstInstall() = 0;

- // Returns system hash in hex encoded ascii format.

+ // Returns system hash in hex encoded ascii format. Note: this may return

+ // an empty string (e.g. if cryptohome is not running). It is up to the

+ // calling function to try again after a delay if desired.

virtual std::string GetSystemSalt() = 0;

// Encrypts |token| with the system salt key (stable for the lifetime