chrome/browser/chromeos/login/parallel_authenticator.cc - Issue 23903051: Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/parallel_authenticator.cc

Issue 23903051: Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/parallel_authenticator.cc

diff --git a/chrome/browser/chromeos/login/parallel_authenticator.cc b/chrome/browser/chromeos/login/parallel_authenticator.cc

index 54b5aaf7e8e5cbffd9f6d14ea0bfe758958f2015..85f724d8e604f8c672d46b3f9a00b901e1d85a13 100644

--- a/chrome/browser/chromeos/login/parallel_authenticator.cc

+++ b/chrome/browser/chromeos/login/parallel_authenticator.cc

@@ -187,6 +187,8 @@ std::string HashPassword(const std::string& password) {

// Get salt, ascii encode, update sha with that, then update with ascii

// of password, then end.

std::string ascii_salt = CryptohomeLibrary::Get()->GetSystemSalt();

+ // TODO(stevenjb/nkostylev): Handle empty system salt gracefully.

+ CHECK(!ascii_salt.empty());

char passhash_buf[kPasswordHashLength];

// Hash salt and password