Eliminate CHECK from CryptohomeLibrary::LoadSystemSalt

chrome/browser/renderer_host/pepper/device_id_fetcher.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_PEPPER_DEVICE_ID_FETCHER_H_
 #define CHROME_BROWSER_RENDERER_HOST_PEPPER_DEVICE_ID_FETCHER_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
 #include "ppapi/c/pp_instance.h"
 
 class Profile;
 
 namespace content {
 class BrowserPpapiHost;
 }
 
 namespace user_prefs {
 class PrefRegistrySyncable;
@@ skipping 18 matching lines @@
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* prefs);
 
   // Return the path where the legacy device ID is stored (for ChromeOS only).
   static base::FilePath GetLegacyDeviceIDPath(
       const base::FilePath& profile_path);
 
  private:
   ~DeviceIDFetcher();
 
   // Checks the preferences for DRM (whether DRM is enabled and getting the drm
-  // salt) on the UI thread. These are passed to |ComputeOnIOThread|.
+  // salt) on the UI thread.
   void CheckPrefsOnUIThread();
 
-  // Compute the device ID on the IO thread with the given salt.
-  void ComputeOnIOThread(const std::string& salt);
+  // Compute the device ID on the UI thread with the given salt and machine ID.
+  void ComputeOnUIThread(const std::string& salt,
+                         const std::string& machine_id);
+
   // Legacy method used to get the device ID for ChromeOS.
-  void ComputeOnBlockingPool(const base::FilePath& profile_path,
-                             const std::string& salt);
+  // static to avoid WeakPtr access on the blocking pool thread.
+  static void LegacyComputeOnBlockingPool(
+      base::WeakPtr<DeviceIDFetcher> fetcher,
+      const base::FilePath& profile_path,
+      const std::string& salt);
 
   // Runs the callback passed into Start() on the IO thread with the device ID
   // or the empty string on failure.
   void RunCallbackOnIOThread(const std::string& id);
 
-  // Helper which returns an ID unique to the system. Returns an empty string if
-  // the call fails.
-  std::string GetMachineID();
-
   friend class base::RefCountedThreadSafe<DeviceIDFetcher>;
 
   // The callback to run when the ID has been fetched.
   IDCallback callback_;
 
   // Whether a request is in progress.
   bool in_progress_;
 
   int render_process_id_;
 
+  base::WeakPtrFactory<DeviceIDFetcher> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(DeviceIDFetcher);
 };
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_PEPPER_DEVICE_ID_FETCHER_H_