Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 23903045: Define a gyp variable pointing to icu.gyp. (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
Reviewers:
marja
CC:
chromium-reviews
Visibility:
Public.

Description

Define a gyp variable pointing to icu.gyp. I plan to use this from v8.gyp to avoid <(DEPTH) within v8. BUG=none R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-12 12:45:15 UTC) #1
marja
lgtm
7 years, 3 months ago (2013-09-12 12:51:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/23903045/1
7 years, 3 months ago (2013-09-12 12:52:14 UTC) #3
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-12 13:29:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r222777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698