Source/core/css/CSSValueList.cpp - Issue 23903041: Make the Vector copy constructor for mismatched inline sizes explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSValueList.cpp

Issue 23903041: Make the Vector copy constructor for mismatched inline sizes explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSValueList.cpp

diff --git a/Source/core/css/CSSValueList.cpp b/Source/core/css/CSSValueList.cpp

index 26ab9c05432447a023a5890bea2b28af5d2ad7ae..060415245184b1422172576cdc0fa1d1cdbffe46 100644

--- a/Source/core/css/CSSValueList.cpp

+++ b/Source/core/css/CSSValueList.cpp

@@ -127,7 +127,7 @@ String CSSValueList::customCssText(CssTextFormattingFlags formattingFlag) const

bool CSSValueList::equals(const CSSValueList& other) const

{

- return m_valueListSeparator == other.m_valueListSeparator && compareCSSValueVector<CSSValue>(m_values, other.m_values);

+ return m_valueListSeparator == other.m_valueListSeparator && compareCSSValueVector<CSSValue>(Vector<RefPtr<CSSValue> >(m_values), Vector<RefPtr<CSSValue> >(other.m_values));

abarth-chromium 2013/09/11 18:16:41 This has got to be wrong. Can you add a FIXME com

}

bool CSSValueList::equals(const CSSValue& other) const

« no previous file with comments | « Source/core/css/CSSParser-in.cpp ('k') | Source/core/html/track/WebVTTTokenizer.cpp » ('j') | Source/core/html/track/WebVTTTokenizer.cpp » ('J')