Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/core/scripts/templates/StylePropertyShorthand.cpp.tmpl

Issue 23903041: Make the Vector copy constructor for mismatched inline sizes explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Review feedback. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/modules/indexeddb/IDBObjectStore.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2013 Intel Corporation. All rights reserved. 4 * Copyright (C) 2013 Intel Corporation. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 const Vector<StylePropertyShorthand> matchingShorthandsForLonghand(CSSPropertyID propertyID) 67 const Vector<StylePropertyShorthand> matchingShorthandsForLonghand(CSSPropertyID propertyID)
68 { 68 {
69 DEFINE_STATIC_LOCAL(longhandsMap, map, ()); 69 DEFINE_STATIC_LOCAL(longhandsMap, map, ());
70 if (map.isEmpty()) { 70 if (map.isEmpty()) {
71 {%- for longhand_id, shorthands in longhands_dictionary.items() %} 71 {%- for longhand_id, shorthands in longhands_dictionary.items() %}
72 72
73 Vector<StylePropertyShorthand, {{ shorthands|length }}> {{ longhand_id } }Shorthands; 73 Vector<StylePropertyShorthand, {{ shorthands|length }}> {{ longhand_id } }Shorthands;
74 {% for shorthand in shorthands -%} 74 {% for shorthand in shorthands -%}
75 {{ longhand_id }}Shorthands.uncheckedAppend({{ shorthand.camel_case_ name }}Shorthand()); 75 {{ longhand_id }}Shorthands.uncheckedAppend({{ shorthand.camel_case_ name }}Shorthand());
76 {% endfor -%} 76 {% endfor -%}
77 map.set({{ longhand_id }}, {{ longhand_id }}Shorthands); 77 // FIXME: the explicit Vector conversion copies into a temporary and is
78 // wasteful.
79 map.set({{ longhand_id }}, Vector<StylePropertyShorthand>({{ longhand_id }}Shorthands));
78 {%- endfor %} 80 {%- endfor %}
79 } 81 }
80 return map.get(propertyID); 82 return map.get(propertyID);
81 } 83 }
82 84
83 } // namespace WebCore 85 } // namespace WebCore
84 86
OLDNEW
« no previous file with comments | « Source/core/page/EventHandler.cpp ('k') | Source/modules/indexeddb/IDBObjectStore.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698