Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: runtime/vm/heap_histogram.cc

Issue 23903034: - Disallow copy constructors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/disassembler.cc ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/heap_histogram.cc
===================================================================
--- runtime/vm/heap_histogram.cc (revision 27344)
+++ runtime/vm/heap_histogram.cc (working copy)
@@ -161,19 +161,19 @@
JSONObject jsobj(stream);
jsobj.AddProperty("type", "ObjectHistogram");
{ // TODO(johnmccutchan): Why is this empty array needed here?
- JSONArray jsarr(jsobj, "properties");
+ JSONArray jsarr(&jsobj, "properties");
jsarr.AddValue("size");
jsarr.AddValue("count");
}
{
- JSONArray jsarr(jsobj, "members");
+ JSONArray jsarr(&jsobj, "members");
for (intptr_t pos = 0; pos < length; pos++) {
Element* e = array[pos];
if (e->count_ > 0) {
cls = isolate_->class_table()->At(e->class_id_);
str = cls.Name();
lib = cls.library();
- JSONObject jsobj(jsarr);
+ JSONObject jsobj(&jsarr);
jsobj.AddProperty("type", "ObjectHistogramEntry");
// It should not be possible to overflow here because the total
// size of the heap is bounded and we are dividing the value
@@ -196,7 +196,7 @@
}
}
}
- JSONObject sums(jsobj, "sums");
+ JSONObject sums(&jsobj, "sums");
sums.AddProperty("size", size_sum);
sums.AddProperty("count", count_sum);
« no previous file with comments | « runtime/vm/disassembler.cc ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698