Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2390303003: MIPS: Fix segment alignment. (Closed)

Created:
4 years, 2 months ago by miran.karic
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix segment alignment. Recent changes in Segment class caused many tests to fail on mips32 because of an unaligned read error. Setting the alignment to 8 for mips fixes the issue. Accessing doubles on mips32 must be eight bit aligned. BUG= Committed: https://crrev.com/a943c9e4d8b144c6cdf276e5245a0b8c3390e6a2 Cr-Commit-Position: refs/heads/master@{#40039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/zone/zone.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
miran.karic
PTAL
4 years, 2 months ago (2016-10-04 15:50:02 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-06 12:14:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390303003/1
4 years, 2 months ago (2016-10-06 13:04:51 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 13:57:48 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 13:58:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a943c9e4d8b144c6cdf276e5245a0b8c3390e6a2
Cr-Commit-Position: refs/heads/master@{#40039}

Powered by Google App Engine
This is Rietveld 408576698