Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/compiler/pipeline.cc

Issue 2390303002: [turbofan] Check instruction input/output count limits in instruction selector. (Closed)
Patch Set: Fix silly mistakes in the test. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | test/mjsunit/compiler/regress-625966.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index 0041da25bf31e00b18b135849e1ddf97c1f2390d..294caf89e87f13b99983a93963315c9635988de1 100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -1233,7 +1233,9 @@ struct InstructionSelectionPhase {
data->info()->is_source_positions_enabled()
? InstructionSelector::kAllSourcePositions
: InstructionSelector::kCallSourcePositions);
- selector.SelectInstructions();
+ if (!selector.SelectInstructions()) {
+ data->set_compilation_failed();
+ }
}
};
@@ -1754,6 +1756,11 @@ bool PipelineImpl::ScheduleAndSelectInstructions(Linkage* linkage) {
data->InitializeFrameData(call_descriptor);
// Select and schedule instructions covering the scheduled graph.
Run<InstructionSelectionPhase>(linkage);
+ if (data->compilation_failed()) {
+ info()->AbortOptimization(kCodeGenerationFailed);
+ data->EndPhaseKind();
+ return false;
+ }
if (FLAG_trace_turbo && !data->MayHaveUnverifiableGraph()) {
AllowHandleDereference allow_deref;
« no previous file with comments | « src/compiler/instruction-selector.cc ('k') | test/mjsunit/compiler/regress-625966.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698