Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2390303002: [turbofan] Check instruction input/output count limits in instruction selector. (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Check instruction input/output count limits in instruction selector. BUG=chromium:625966 Committed: https://crrev.com/a974970cffae3380c2b96cc5fc6210bd5826871c Cr-Commit-Position: refs/heads/master@{#39970}

Patch Set 1 #

Patch Set 2 : Fix silly mistakes in the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -19 lines) Patch
M src/compiler/instruction.h View 2 chunks +8 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 8 chunks +23 lines, -9 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +8 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/regress-625966.js View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Jarin
Could you take a look, please?
4 years, 2 months ago (2016-10-04 14:53:32 UTC) #4
Benedikt Meurer
LGTM, thanks.
4 years, 2 months ago (2016-10-05 03:10:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390303002/20001
4 years, 2 months ago (2016-10-05 05:41:47 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 05:43:25 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 05:43:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a974970cffae3380c2b96cc5fc6210bd5826871c
Cr-Commit-Position: refs/heads/master@{#39970}

Powered by Google App Engine
This is Rietveld 408576698