Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 23903025: Close Views HTML authentication and tab modal confirm dialogs on interstitial WebUI (Closed)

Created:
7 years, 3 months ago by Mike Wittman
Modified:
7 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Close Views HTML authentication and tab modal confirm dialogs on interstitial WebUI Configure Views HTML authentication and tab modal confirm dialogs to be closed when interstitial WebUI is displayed (e.g. for SSL warnings prior to page load). This is effectively a no-op for these dialogs, but is desirable so that all web contents modal dialogs have consistently configured behavior; these dialogs are already closed at load start time which occurs before interstitial WebUI is displayed. BUG=240575 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/ui/views/login_prompt_views.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_modal_confirm_dialog_views.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike Wittman
7 years, 3 months ago (2013-09-09 23:14:48 UTC) #1
sky
LGTM
7 years, 3 months ago (2013-09-09 23:37:58 UTC) #2
Mike Wittman
7 years, 3 months ago (2013-09-09 23:48:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r222130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698