Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23903024: Enable device discovery notifications. (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enable device discovery notifications. Add kill switch for notifications. Disable notifications for task manager test. BUG=286157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223106

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/privet_notifications_factory.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 3 months ago (2013-09-10 00:55:58 UTC) #1
Lei Zhang
https://codereview.chromium.org/23903024/diff/39001/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/23903024/diff/39001/chrome/common/chrome_switches.cc#newcode328 chrome/common/chrome_switches.cc:328: = "disable-device-discovery"; Wrong name?
7 years, 3 months ago (2013-09-10 01:00:29 UTC) #2
Vitaly Buka (NO REVIEWS)
On 2013/09/10 01:00:29, Lei Zhang wrote: > https://codereview.chromium.org/23903024/diff/39001/chrome/common/chrome_switches.cc > File chrome/common/chrome_switches.cc (right): > > https://codereview.chromium.org/23903024/diff/39001/chrome/common/chrome_switches.cc#newcode328 ...
7 years, 3 months ago (2013-09-10 01:01:32 UTC) #3
Lei Zhang
lgtm
7 years, 3 months ago (2013-09-10 01:27:27 UTC) #4
Noam Samuel
On 2013/09/10 01:27:27, Lei Zhang wrote: > lgtm lgtm
7 years, 3 months ago (2013-09-10 01:30:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/12001
7 years, 3 months ago (2013-09-10 01:31:46 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 01:45:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/12001
7 years, 3 months ago (2013-09-10 02:20:02 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:29:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/68001
7 years, 3 months ago (2013-09-10 04:10:22 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167165
7 years, 3 months ago (2013-09-10 06:14:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/68001
7 years, 3 months ago (2013-09-10 06:18:20 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=167217
7 years, 3 months ago (2013-09-10 07:02:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/68001
7 years, 3 months ago (2013-09-10 07:52:58 UTC) #14
commit-bot: I haz the power
Change committed as 222238
7 years, 3 months ago (2013-09-10 09:21:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/85001
7 years, 3 months ago (2013-09-10 18:16:19 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 18:51:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/85002
7 years, 3 months ago (2013-09-10 19:17:36 UTC) #18
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
7 years, 3 months ago (2013-09-10 19:17:37 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/103001
7 years, 3 months ago (2013-09-10 23:02:15 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/45001
7 years, 3 months ago (2013-09-12 09:34:52 UTC) #21
Vitaly Buka (NO REVIEWS)
+tommi for chrome_frame/test/net/fake_external_tab.cc
7 years, 3 months ago (2013-09-12 09:44:43 UTC) #22
Vitaly Buka (NO REVIEWS)
+robertshield for chrome_frame/
7 years, 3 months ago (2013-09-12 17:20:13 UTC) #23
robertshield
lgtm
7 years, 3 months ago (2013-09-12 17:33:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/45001
7 years, 3 months ago (2013-09-12 17:45:51 UTC) #25
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=78328
7 years, 3 months ago (2013-09-13 02:30:49 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/23903024/45001
7 years, 3 months ago (2013-09-13 17:48:20 UTC) #27
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 20:11:48 UTC) #28
Message was sent while issue was closed. 
Change committed as 223106

Powered by Google App Engine
This is Rietveld 408576698