Add --mediadrm-enable-non-compositing flag for Chrome on Android.

Add --mediadrm-enable-non-compositing flag for Chrome on Android.

When this flag is enabled, we'll use a non-compositing decoder in
MediaDrm by default. Otherwise, a compositing decoder will be used
by default.

TBR=ddorwin@chromium.org, qinmin@chromium.org
BUG=163552
TEST=Tried on Nexus 7 with and without this flag.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222181

[xhwang, 2013-09-09 22:05:49]

As discussed offline. PTAL

[ddorwin, 2013-09-09 22:16:34]

nits

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6048: +        <message
name="IDS_FLAGS_MEDIADRM_ENABLE_NON_COMPOSITING_NAME" desc="Mobile: Title for
the flag to enable non-conmpositing decoding in MediaDrm for encrypted
contents.">
"Mobile"? Or "Android"? It doesn't apply to iOS.
s/contents/content/?

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6049: +          Enable non-compositing
decoding in MediaDrm.
Probably don't need to tell the user details about the implementation (" in
MediaDrm").

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6051: +        <message
name="IDS_FLAGS_MEDIADRM_ENABLE_NON_COMPOSITING_DESCRIPTION" desc="Mobile:
Description for the flag to enable non-conmpositing decoding in MediaDrm for
encrypted contents.">
The above items apply here too.

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6052: +          Enable non-compositing
decoding in MediaDrm by default for Encrypted Media Extension implementation.
Extension_s_

https://codereview.chromium.org/23903023/diff/1/media/base/media_switches.cc
File media/base/media_switches.cc (right):

https://codereview.chromium.org/23903023/diff/1/media/base/media_switches.cc#...
media/base/media_switches.cc:32: // MediaDrm uses non-compositing decoding by
default for Encrypted Media
// Enables use of non-compositing MediaDrm decoding...

[qinmin, 2013-09-09 22:23:04]

https://codereview.chromium.org/23903023/diff/1/content/browser/android/brows...
File content/browser/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/23903023/diff/1/content/browser/android/brows...
content/browser/android/browser_media_player_manager.cc:533:
MediaDrmBridge::Create(media_keys_id, uuid, security_level, this));
the java side MediaDrmBridge.Create() call will return a non-null object if
SetProperty(L1) fails.
If we want to enforce L1, it should return NULL.

[xhwang, 2013-09-09 22:52:48]

PTAL again

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6048: +        <message
name="IDS_FLAGS_MEDIADRM_ENABLE_NON_COMPOSITING_NAME" desc="Mobile: Title for
the flag to enable non-conmpositing decoding in MediaDrm for encrypted
contents.">
On 2013/09/09 22:16:34, ddorwin wrote:
> "Mobile"? Or "Android"? It doesn't apply to iOS.
> s/contents/content/?

Done.

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6049: +          Enable non-compositing
decoding in MediaDrm.
On 2013/09/09 22:16:34, ddorwin wrote:
> Probably don't need to tell the user details about the implementation (" in
> MediaDrm").

Done.

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6051: +        <message
name="IDS_FLAGS_MEDIADRM_ENABLE_NON_COMPOSITING_DESCRIPTION" desc="Mobile:
Description for the flag to enable non-conmpositing decoding in MediaDrm for
encrypted contents.">
On 2013/09/09 22:16:34, ddorwin wrote:
> The above items apply here too.

Done.

https://codereview.chromium.org/23903023/diff/1/chrome/app/generated_resource...
chrome/app/generated_resources.grd:6052: +          Enable non-compositing
decoding in MediaDrm by default for Encrypted Media Extension implementation.
On 2013/09/09 22:16:34, ddorwin wrote:
> Extension_s_

Done.

https://codereview.chromium.org/23903023/diff/1/content/browser/android/brows...
File content/browser/android/browser_media_player_manager.cc (right):

https://codereview.chromium.org/23903023/diff/1/content/browser/android/brows...
content/browser/android/browser_media_player_manager.cc:533:
MediaDrmBridge::Create(media_keys_id, uuid, security_level, this));
On 2013/09/09 22:23:05, qinmin wrote:
> the java side MediaDrmBridge.Create() call will return a non-null object if
> SetProperty(L1) fails.
> If we want to enforce L1, it should return NULL.

Since last CL
(https://codereview.chromium.org/23480036/diff/45001/media/base/android/java/s...),
MediaDrmBridge.Create() returns NULL when SetProperty(L1) fails.

https://codereview.chromium.org/23903023/diff/1/media/base/media_switches.cc
File media/base/media_switches.cc (right):

https://codereview.chromium.org/23903023/diff/1/media/base/media_switches.cc#...
media/base/media_switches.cc:32: // MediaDrm uses non-compositing decoding by
default for Encrypted Media
On 2013/09/09 22:16:34, ddorwin wrote:
> // Enables use of non-compositing MediaDrm decoding...

Done.

[qinmin, 2013-09-09 22:53:53]

lgtm

[ddorwin, 2013-09-09 23:13:26]

lgtm with suggestion

https://codereview.chromium.org/23903023/diff/10001/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/23903023/diff/10001/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6052: +          Enable non-compositing
decoding in MediaDrm by default for Encrypted Media Extensions implementation.
I would drop " implementation".

[xhwang, 2013-09-09 23:21:29]

https://codereview.chromium.org/23903023/diff/10001/chrome/app/generated_reso...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/23903023/diff/10001/chrome/app/generated_reso...
chrome/app/generated_resources.grd:6052: +          Enable non-compositing
decoding in MediaDrm by default for Encrypted Media Extensions implementation.
On 2013/09/09 23:13:26, ddorwin wrote:
> I would drop " implementation".

Done.

[commit-bot: I haz the power, 2013-09-09 23:22:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/23903023/2

[xhwang, 2013-09-10 02:03:01]

Committed patchset #5 manually as r222181 (presubmit successful).