Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 23903016: file_manager: Rename root_path to root_url (Closed)

Created:
7 years, 3 months ago by satorux1
Modified:
7 years, 3 months ago
Reviewers:
kinuko, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

file_manager: Rename root_path to root_url The term path is incorrect as the parameter is for a URL. FWIW, the URL looks like: "filesystem:chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/external/" where hhaomjibdihmijegdhdafkllkbggdgoj is the app ID for Files.app. BUG=284963 TEST=Files.app works as before R=benwells@chromium.org, kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221981

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/file_browser_private_custom_bindings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/file_browser_private_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
7 years, 3 months ago (2013-09-05 07:27:37 UTC) #1
kinuko
lgtm
7 years, 3 months ago (2013-09-05 07:30:15 UTC) #2
benwells
https://codereview.chromium.org/23903016/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc (right): https://codereview.chromium.org/23903016/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc#newcode193 chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:193: const GURL& root_url) { Should there be a matching ...
7 years, 3 months ago (2013-09-09 05:04:20 UTC) #3
satorux1
https://codereview.chromium.org/23903016/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc (right): https://codereview.chromium.org/23903016/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc#newcode193 chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:193: const GURL& root_url) { On 2013/09/09 05:04:20, benwells wrote: ...
7 years, 3 months ago (2013-09-09 05:27:28 UTC) #4
benwells
lgtm
7 years, 3 months ago (2013-09-09 05:49:39 UTC) #5
satorux1
7 years, 3 months ago (2013-09-09 06:27:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r221981 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698