Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 23903015: Remove deprecated markersForNode(Node* node) (Closed)

Created:
7 years, 3 months ago by grzegorz
Modified:
7 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Remove deprecated markersForNode(Node* node) DocumentMarkerController::markersForNode(Node* node) has been marked as deprecated in favor of markersFor(Node*, MarkerTypes = AllMarkers()). WebKit changeset: http://trac.webkit.org/changeset/155095 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M Source/core/dom/DocumentMarkerController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grzegorz
7 years, 3 months ago (2013-09-05 07:18:02 UTC) #1
Hajime Morrita
lgtm.
7 years, 3 months ago (2013-09-05 07:20:00 UTC) #2
grzegorz
On 2013/09/05 07:20:00, morrita1 wrote: > lgtm. Thanks. Could you commit this CL? I don't ...
7 years, 3 months ago (2013-09-05 07:33:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/23903015/1
7 years, 3 months ago (2013-09-05 09:27:40 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 10:19:31 UTC) #5
Message was sent while issue was closed.
Change committed as 157294

Powered by Google App Engine
This is Rietveld 408576698