Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2390293002: Fix a null ptr crash on a empty body response on mojo loading (Closed)

Created:
4 years, 2 months ago by tzik
Modified:
4 years, 2 months ago
Reviewers:
jam, yhirano
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a null ptr crash on a empty body response on mojo loading |body_consumer_| can be null on a request completion of an empty body response. BUG=603396 Committed: https://crrev.com/32125d6a67379d78518aa612886b29b7f055fca3 Cr-Commit-Position: refs/heads/master@{#423443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/child/resource_dispatcher.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
tzik
PTAL
4 years, 2 months ago (2016-10-05 03:32:22 UTC) #7
yhirano
lgtm, thanks!
4 years, 2 months ago (2016-10-05 03:33:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390293002/1
4 years, 2 months ago (2016-10-05 03:53:23 UTC) #10
tzik
Adding jam@ as a //content owner. PTAL.
4 years, 2 months ago (2016-10-05 04:00:26 UTC) #13
jam
lgtm
4 years, 2 months ago (2016-10-05 16:25:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390293002/1
4 years, 2 months ago (2016-10-06 03:56:06 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 05:29:27 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 05:33:29 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32125d6a67379d78518aa612886b29b7f055fca3
Cr-Commit-Position: refs/heads/master@{#423443}

Powered by Google App Engine
This is Rietveld 408576698