Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2390233002: [wasm] Adjust crash message of the correctness fuzzer to avoid clustering. (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
aarya, mmoroz, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Adjust crash message of the correctness fuzzer to avoid clustering. The correctness fuzzer executes the input array in two different execution engines and compares the results. If the results don't match, the correctness fuzzer crashes. Since the crash signature is always the same if the results don't match, cluster fuzz would group all inputs which lead to non-matching results. To avoid the grouping a base64 hash has to be appended to the crash signature. This CL changes the text which is appended to the crash signature to a base64 hash. Note that I do not create a base64 hash directly because the base64 class is not available in V8. Instead I create a string which looks like a base64 hash. R=mmoroz@chromium.org, aarya@chromium.org, titzer@chromium.org Committed: https://crrev.com/55da769bafac8b531cd8b388df56161b8b7c6416 Cr-Commit-Position: refs/heads/master@{#39953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M test/fuzzer/wasm-code.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
ahaas
4 years, 2 months ago (2016-10-04 10:02:54 UTC) #1
mmoroz
LGTM, hope it will work as we expect
4 years, 2 months ago (2016-10-04 11:00:29 UTC) #6
titzer
lgtm. We might have to explore a bit more to get the right clustering.
4 years, 2 months ago (2016-10-04 12:12:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390233002/1
4 years, 2 months ago (2016-10-04 12:15:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 12:17:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 12:18:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55da769bafac8b531cd8b388df56161b8b7c6416
Cr-Commit-Position: refs/heads/master@{#39953}

Powered by Google App Engine
This is Rietveld 408576698