Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/user_prefs/tracked/tracked_atomic_preference.cc

Issue 2390213002: Revert of Send a TrackedPreference incident when registry pref validation fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/tracked_atomic_preference.cc
diff --git a/components/user_prefs/tracked/tracked_atomic_preference.cc b/components/user_prefs/tracked/tracked_atomic_preference.cc
index e2b76784b81a7be1685d390f92c06d2be5dbe4c8..2415d7f844a909a3ebbdcbd70741b05c8dff52ae 100644
--- a/components/user_prefs/tracked/tracked_atomic_preference.cc
+++ b/components/user_prefs/tracked/tracked_atomic_preference.cc
@@ -45,18 +45,19 @@
helper_.ReportValidationResult(value_state, transaction->GetStoreUMASuffix());
PrefHashStoreTransaction::ValueState external_validation_value_state =
- PrefHashStoreTransaction::UNSUPPORTED;
+ PrefHashStoreTransaction::UNCHANGED;
if (external_validation_transaction) {
external_validation_value_state =
external_validation_transaction->CheckValue(pref_path_, value);
helper_.ReportValidationResult(
external_validation_value_state,
external_validation_transaction->GetStoreUMASuffix());
+
+ // TODO(proberge): Call delegate_->OnAtomicPreferenceValidation.
}
if (delegate_) {
delegate_->OnAtomicPreferenceValidation(pref_path_, value, value_state,
- external_validation_value_state,
helper_.IsPersonal());
}
TrackedPreferenceHelper::ResetAction reset_action =

Powered by Google App Engine
This is Rietveld 408576698