Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 23902033: Add mutex when accessing concurrent recompilation output queue. (Closed)

Created:
7 years, 3 months ago by Yang
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add mutex when accessing concurrent recompilation output queue. Also small refactorings. R=mstarzinger@chromium.org BUG=291236 Committed: https://code.google.com/p/v8/source/detail?r=16740

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/execution.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/optimizing-compiler-thread.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/optimizing-compiler-thread.cc View 1 5 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 3 months ago (2013-09-16 14:40:31 UTC) #1
Michael Starzinger
LGTM if comment about the stack guard is addressed. https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc File src/optimizing-compiler-thread.cc (right): https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc#newcode140 src/optimizing-compiler-thread.cc:140: ...
7 years, 3 months ago (2013-09-16 15:28:19 UTC) #2
Yang
7 years, 3 months ago (2013-09-16 15:34:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698