Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: tools/perf/metrics/timeline.py

Issue 23902027: telemetry: Make trace profiler work with trace-based benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tracking nesting calls on Start/StopTracing. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/metrics/timeline.py
diff --git a/tools/perf/metrics/timeline.py b/tools/perf/metrics/timeline.py
index 646264699395124f9b11bb615e07bb672151950f..6d9ef26e8d82815210d8c5c4b951a7f8a0f60043 100644
--- a/tools/perf/metrics/timeline.py
+++ b/tools/perf/metrics/timeline.py
@@ -38,8 +38,7 @@ class TimelineMetric(Metric):
console.timeEnd("__loading_measurement_was_here__");
""")
- tab.browser.StopTracing()
- trace_result = tab.browser.GetTraceResultAndReset()
+ trace_result = tab.browser.StopTracing()
self._model = trace_result.AsTimelineModel()
events = [s for
s in self._model.GetAllEventsOfName(
@@ -68,4 +67,3 @@ class TimelineMetric(Metric):
results.Add(event_name, 'ms', total)
results.Add(event_name + '_max', 'ms', biggest_jank)
results.Add(event_name + '_avg', 'ms', total / len(times))
-

Powered by Google App Engine
This is Rietveld 408576698