Issue 23902018: pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the param…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23902018: pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the param…

Created:
7 years, 3 months ago by edisonn

Modified:
7 years, 3 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

pdfviewer: do not submit, uploaded for backup, and will be done actually after I refactor the params for functions, to put the char* params in a structure: report errors and warnings in pdf, infrastructure

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+352 lines, -162 lines)			Patch
M	experimental/PdfViewer/SkPdfConfig.h	View	1 2 3 4 5 6	2 chunks	+33 lines, -0 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfRenderer.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	experimental/PdfViewer/SkPdfRenderer.cpp	View	1 2 3 4 5	87 chunks	+248 lines, -124 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeDoc.cpp	View	1 2 3 4 5 6	17 chunks	+28 lines, -17 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.h	View	1 2 3	1 chunk	+20 lines, -14 lines	0 comments	Download
	experimental/PdfViewer/pdfparser/native/SkPdfNativeObject.cpp	View	1 2 3 4 5 6	6 chunks	+10 lines, -5 lines	0 comments	Download
M	experimental/PdfViewer/pdfparser/native/SkPdfNativeTokenizer.cpp	View	1 2 3 4 5 6	1 chunk	+6 lines, -2 lines	0 comments	Download
M	gyp/pdfviewer_lib.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download