Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 23902004: Allow configuring CPU profiler sampling interval using public API (Closed)

Created:
7 years, 3 months ago by yurys
Modified:
7 years, 3 months ago
CC:
v8-dev, alph
Visibility:
Public.

Description

Allow configuring CPU profiler sampling interval using public API The only way to change it at the moment is using a command line flag. We are going to add a setting to Chrome DevTools which would allow chaning default interval and that requires proper v8 API. BUG=v8:2814 R=bmeurer@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M include/v8-profiler.h View 1 chunk +4 lines, -6 lines 0 comments Download
M src/api.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/cpu-profiler.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/cpu-profiler.cc View 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 3 months ago (2013-09-04 09:32:09 UTC) #1
loislo
lgtm
7 years, 3 months ago (2013-09-04 09:53:24 UTC) #2
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-04 11:15:17 UTC) #3
yurys
7 years, 3 months ago (2013-09-04 11:55:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r16525 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698