Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 2390193002: Automatically refresh the page when the flash permission prompt is allowed (Closed)

Created:
4 years, 2 months ago by raymes
Modified:
4 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Automatically refresh the page when the flash permission prompt is allowed Rather than showing the infobar, just refresh the page. The user would usually arrive in this situation because they've clicked a link to obtain flash, so refreshing the page shouldn't be problematic. BUG=641615, 652479 Committed: https://crrev.com/72b177c537aedc0e2625bbd7d4660b261a3d1264 Cr-Commit-Position: refs/heads/master@{#422945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/plugins/flash_permission_context.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
raymes
4 years, 2 months ago (2016-10-04 06:07:50 UTC) #2
tommycli
lgtm thanks!
4 years, 2 months ago (2016-10-04 17:25:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390193002/1
4 years, 2 months ago (2016-10-04 21:37:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 21:43:52 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:46:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72b177c537aedc0e2625bbd7d4660b261a3d1264
Cr-Commit-Position: refs/heads/master@{#422945}

Powered by Google App Engine
This is Rietveld 408576698