Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2390173002: Fix wrong transform for motion-path (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
pdr., Eric Willigers
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix wrong transform for motion-path We call ComputedStyle::applyTransform(..., ExcludeTransformOrigin, IncludeMotionPath, ...) in PaintPropertyTreeBuilder updateTransform(). Previously in the case applyTransform() passed wrong (0,0) origin when calling applyMotionPathTransform(). Always pass the correct origin to applyMotionPathTransform(). BUG=652323 TEST=css3/motion-path/path-establishes-stacking-context.html with --enable-blink-features=slimmingPaintInvalidation Committed: https://crrev.com/59e73da2ef6b12fe29ffb65e2f7165f57d495118 Cr-Commit-Position: refs/heads/master@{#422970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Xianzhu
4 years, 2 months ago (2016-10-04 15:36:34 UTC) #6
Eric Willigers
lgtm
4 years, 2 months ago (2016-10-04 19:13:32 UTC) #7
Xianzhu
pdr@ can you also take a look?
4 years, 2 months ago (2016-10-04 21:40:25 UTC) #8
pdr.
On 2016/10/04 at 21:40:25, wangxianzhu wrote: > pdr@ can you also take a look? LGTM
4 years, 2 months ago (2016-10-04 22:05:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390173002/1
4 years, 2 months ago (2016-10-04 22:25:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 22:31:34 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 22:34:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59e73da2ef6b12fe29ffb65e2f7165f57d495118
Cr-Commit-Position: refs/heads/master@{#422970}

Powered by Google App Engine
This is Rietveld 408576698