Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: media/audio/audio_input_writer.h

Issue 2390153006: Audio input debug recording refactoring to reduce thread hops and simplify object ownership (Closed)
Patch Set: review comments addressed Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_input_writer.h
diff --git a/media/audio/audio_input_writer.h b/media/audio/audio_input_writer.h
index 42ca0ba42d6e43c10445261355d6e4bc0f00d4f6..eef97a4240064c675076ecdd9203d7beb69e0740 100644
--- a/media/audio/audio_input_writer.h
+++ b/media/audio/audio_input_writer.h
@@ -17,8 +17,21 @@ class AudioInputWriter {
public:
virtual ~AudioInputWriter() {}
+ // Must be called before calling Write() for the first time after creation or
+ // Stop() call. Can be called on any sequence; Write() and Stop() must be
+ // called on the same sequence as Start().
+ virtual void Start(const base::FilePath& file) = 0;
+
+ // Must be called to finish recording. Each call to Start() requires a call to
+ // Stop(). Will be automatically called on destruction.
+ virtual void Stop() = 0;
+
// Write |data| to file.
virtual void Write(std::unique_ptr<AudioBus> data) = 0;
+
+ // Returns true if it makes sense to schedule Write() calls. Can be called
Henrik Grunell 2016/10/11 13:07:24 And when does it make sense? :) Describe, so that
o1ka 2016/10/11 14:04:37 Done.
+ // from any sequence.
+ virtual bool WillWrite() = 0;
};
} // namspace media

Powered by Google App Engine
This is Rietveld 408576698