Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2390113003: [wasm] Refactor import handling for 0xC. (Closed)
Patch Set: Add support for exported globals. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index dac9eec7a75a9ee22c49e7ee7ec114822a7f86ef..fef39feb69d9b6e0b87418872eca137385843075 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -3132,8 +3132,8 @@ Handle<Code> CompileJSToWasmWrapper(Isolate* isolate, wasm::ModuleEnv* module,
Handle<Code> CompileWasmToJSWrapper(Isolate* isolate, Handle<JSReceiver> target,
wasm::FunctionSig* sig, uint32_t index,
- Handle<String> import_module,
- MaybeHandle<String> import_function) {
+ Handle<String> module_name,
+ MaybeHandle<String> import_name) {
//----------------------------------------------------------------------------
// Create the Graph
//----------------------------------------------------------------------------
@@ -3196,14 +3196,14 @@ Handle<Code> CompileWasmToJSWrapper(Isolate* isolate, Handle<JSReceiver> target,
if (isolate->logger()->is_logging_code_events() || isolate->is_profiling()) {
const char* function_name = nullptr;
int function_name_size = 0;
- if (!import_function.is_null()) {
- Handle<String> handle = import_function.ToHandleChecked();
+ if (!import_name.is_null()) {
+ Handle<String> handle = import_name.ToHandleChecked();
function_name = handle->ToCString().get();
function_name_size = handle->length();
}
RecordFunctionCompilation(
CodeEventListener::FUNCTION_TAG, isolate, code, "wasm-to-js", index,
- {import_module->ToCString().get(), import_module->length()},
+ {module_name->ToCString().get(), module_name->length()},
{function_name, function_name_size});
}

Powered by Google App Engine
This is Rietveld 408576698