Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2390113002: [Android] Sync location access permmission change when going back to the search engine setting page (Closed)

Created:
4 years, 2 months ago by ltian
Modified:
4 years, 2 months ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Sync location access permmission change when going back to the search engine setting page Force Listview to update in onResume() to synchronize with any change of location access permission of search engines. BUG=652204 Committed: https://crrev.com/a7a67cb99713a6ea6ffc4bef5c0fa81c7ed5296f Cr-Commit-Position: refs/heads/master@{#422827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ltian
Hi, Theresa. Could you take a look of this cl? Thanks!
4 years, 2 months ago (2016-10-04 01:07:22 UTC) #2
Theresa
lgtm
4 years, 2 months ago (2016-10-04 16:12:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390113002/1
4 years, 2 months ago (2016-10-04 16:12:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 16:44:09 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:45:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7a67cb99713a6ea6ffc4bef5c0fa81c7ed5296f
Cr-Commit-Position: refs/heads/master@{#422827}

Powered by Google App Engine
This is Rietveld 408576698