Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html

Issue 2390083002: Text Encoding: Convert fast/encoding tests to testharness.js (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html
diff --git a/third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html b/third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html
index 31632cef6c1f6e74f2f140087d090f6303ce2ac4..8133bf34326c3e95f6023b15256dccd5bb245361 100644
--- a/third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html
+++ b/third_party/WebKit/LayoutTests/fast/encoding/char-encoding.html
@@ -1,23 +1,11 @@
-<html>
-<head>
-<script src="../../resources/js-test.js"></script>
+<!DOCTYPE html>
+<title>Character Encoding</title>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="resources/char-encoding-utils.js"></script>
-</head>
<body>
-<form id="form" method="GET" target="subframe"><input type="text" id="text" name="text"></form>
-<iframe id="subframe" name="subframe"></iframe>
<script>
-
-var charsets = new Array;
-var unicodes = new Array;
-var expectedResults = new Array;
-
-var results = new Object;
-
-var i = 0;
-
-
testEncode("UTF-8", "U+00A0", "%C2%A0");
// Unpaired UTF-16 surrogates
@@ -69,13 +57,7 @@ testEncode("iso-2022-cn", "U+00A0", "%C2%A0");
testEncode("iso-2022-cn-ext", "U+00A0", "%C2%A0");
testEncode("iso-2022-kr", "U+00A0", "%C2%A0");
-// Turning on this test causes a download to occur. FIXME: A bug?
-// testEncode('UTF-8', 'U+221A', '%E2%88%9A');
-
-if (window.testRunner)
- testRunner.waitUntilDone();
-runTest();
-
+// Previously caused an error.
foolip 2016/10/04 09:35:18 This comment will probably look mysterious when up
jsbell 2016/10/04 17:41:39 Good point. Moved it up with the other UTF-8 cases
+testEncode('UTF-8', 'U+221A', '%E2%88%9A');
</script>
</body>
-</html>

Powered by Google App Engine
This is Rietveld 408576698