Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2390063002: Roll cros_system_api and use constants pulled in. (Closed)

Created:
4 years, 2 months ago by Rahul Chaturvedi
Modified:
4 years, 2 months ago
Reviewers:
ortuno
CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll cros_system_api and use constants pulled in. This CL rolls the DEPS to pull in the latest cros_system_api, which adds the constant for the SetAdvertisingIntervals method. It also fixes a few nits from the CL that added the setAdvertisingIntervals code, https://codereview.chromium.org/2353133005/ R=ortuno@chromium.org BUG=637231 Committed: https://crrev.com/fc431404cdeddfa591c11cc833666e673d8f7166 Cr-Commit-Position: refs/heads/master@{#422712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_le_advertising_manager_client.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_le_advertising_manager_client.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Rahul Chaturvedi
4 years, 2 months ago (2016-10-03 23:02:06 UTC) #1
ortuno
lgtm
4 years, 2 months ago (2016-10-04 02:19:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390063002/1
4 years, 2 months ago (2016-10-04 02:33:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 05:23:11 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 05:24:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc431404cdeddfa591c11cc833666e673d8f7166
Cr-Commit-Position: refs/heads/master@{#422712}

Powered by Google App Engine
This is Rietveld 408576698