Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3058)

Unified Diff: chrome/browser/resources/settings/settings_shared_css.html

Issue 2390053002: [MD settings] use arrow-forward to switch direction in rtl (Closed)
Patch Set: in person changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_shared_css.html
diff --git a/chrome/browser/resources/settings/settings_shared_css.html b/chrome/browser/resources/settings/settings_shared_css.html
index 545e4f0f1e5e1ca2f001df798d06b57e671ccba3..f2670ae6260c840c5a834a76162d0405390309a9 100644
--- a/chrome/browser/resources/settings/settings_shared_css.html
+++ b/chrome/browser/resources/settings/settings_shared_css.html
@@ -6,21 +6,21 @@
<template>
<style include="cr-shared-style">
button[is='paper-icon-button-light'] {
- --paper-icon-button-light-ripple: {
- /* Center the ripple on the icon button. */
- height: 36px;
- left: -8px;
- top: -8px;
- width: 36px;
- };
+ -webkit-margin-end: -8px;
Dan Beam 2016/10/04 01:01:00 can haz comment?
dschuyler 2016/10/04 01:13:58 Done.
-webkit-margin-start: 16px;
- background-size: cover;
+ background-position: center;
+ background-repeat: no-repeat;
+ background-size: 20px;
flex-shrink: 0;
- height: 20px;
- width: 20px;
+ height: 36px;
+ width: 36px;
Dan Beam 2016/10/04 01:01:00 can haz variables?
dschuyler 2016/10/04 01:13:58 Done.
+ }
+
+ :host-context([dir=rtl]) button[is='paper-icon-button-light'] {
+ transform: scaleX(-1); /* Flip on the X axis (aka mirror). */
Dan Beam 2016/10/04 01:01:00 arguable nit: \s\s in front of same-line comments
dschuyler 2016/10/04 01:13:58 Done.
}
- [actionable] button[is="paper-icon-button-light"].icon-arrow-right {
+ [actionable] button[is="paper-icon-button-light"].icon-arrow-forward {
background-image: url(images/arrow_right.svg);
}

Powered by Google App Engine
This is Rietveld 408576698