Remove unnecessary duplication of FunctionKind enums in CompilerHints

Remove unnecessary duplication of FunctionKind enums in CompilerHints

The duplicated enum values are only used by the FastNewClosureStub,
so inline them there, with the help of one new constant (kFunctionKindShift)
in SharedFunctionInfo.

Committed: https://crrev.com/7a82be3d0d7d3f0a3aa2d2dfdbe64f495a93245b
Cr-Commit-Position: refs/heads/master@{#40005}

[adamk, 2016-10-04 00:14:19]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 00:14:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 00:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:22:40]

Dry run: Try jobs failed on following builders:
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)

[adamk, 2016-10-04 01:25:49]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 01:25:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 01:52:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 01:52:15]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-10-04 17:08:00]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org

[adamk, 2016-10-04 17:08:01]

Hi Benedikt,

I noticed this enum duplication while doing some modules work. Let me know what
you think; I'm fine if you think it's better to be more explicit here, but it
feels weird to have this enum duplicated, and then require a whole block of
STATIC_ASSERTs.

[adamk, 2016-10-04 18:13:44]

adamk@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[adamk, 2016-10-04 18:13:44]

+mstarzinger (originally sent to bmeurer since he suggested the approach used in
code-stubs.cc).

[Benedikt Meurer, 2016-10-05 03:08:09]

Very nice. LGTM.

[Michael Starzinger, 2016-10-05 08:12:06]

LGTM. I like it! I tried to think of a way to make sure the "magic 10" stays in
sync but couldn't come up with anything nice.

[adamk, 2016-10-05 17:07:01]

On 2016/10/05 08:12:06, Michael Starzinger wrote:
> LGTM. I like it! I tried to think of a way to make sure the "magic 10" stays
in
> sync but couldn't come up with anything nice.

Regarding the magic 10, the only thing I have in mind is introducing a second
enum that's used as part of FunctionKind's definition. But that still has the
ugliness of "duplicate" enums.

[adamk, 2016-10-05 17:07:08]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:07:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:54:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 17:54:50]

Description was changed from

==========
Remove unnecessary duplication of FunctionKind enums in CompilerHints

The duplicated enum values are only used by the FastNewClosureStub,
so inline them there, with the help of one new constant (kFunctionKindShift)
in SharedFunctionInfo.
==========

to

==========
Remove unnecessary duplication of FunctionKind enums in CompilerHints

The duplicated enum values are only used by the FastNewClosureStub,
so inline them there, with the help of one new constant (kFunctionKindShift)
in SharedFunctionInfo.

Committed: https://crrev.com/7a82be3d0d7d3f0a3aa2d2dfdbe64f495a93245b
Cr-Commit-Position: refs/heads/master@{#40005}
==========

[commit-bot: I haz the power, 2016-10-05 17:54:51]

Patchset 2 (id:??) landed as
https://crrev.com/7a82be3d0d7d3f0a3aa2d2dfdbe64f495a93245b
Cr-Commit-Position: refs/heads/master@{#40005}