Issue 239003003: [New Multicolumn] Temporarily changing height is scary and can easily be avoided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239003003: [New Multicolumn] Temporarily changing height is scary and can easily be avoided. (Closed)

Created:
6 years, 8 months ago by mstensho (USE GERRIT)

Modified:
6 years, 8 months ago

Reviewers:
ojan

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[New Multicolumn] Temporarily changing height is scary and can easily be avoided. Storing the height and setting it to zero afterwards, just to be able to calculate desired column height, and to determine if it's auto or not, may have undesired side-effects, and is easily avoidable. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171687

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	Source/core/rendering/RenderBlockFlow.cpp	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/239003003/1

6 years, 8 months ago (2014-04-15 18:54:42 UTC) #3

Message was sent while issue was closed.

Change committed as 171687

Expand Messages | Collapse Messages