Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2389993002: Fix potentially uninitialized value. (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix potentially uninitialized value. Depending on what ReadOK does it's possible for |dircount16| to be used without being initialized. The read code calls back into PDFium specific code which then calls into the stream reading code. Initialize the value to be sure it is set. BUG=chromium:651632 Committed: https://pdfium.googlesource.com/pdfium/+/76383db4906c9357292846ace77566b34eb47de9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
A third_party/libtiff/0007-uninitialized-value.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/libtiff/README.pdfium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libtiff/tif_dirread.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL. I don't know if this is worth upstreaming as the actual implementation code it ...
4 years, 2 months ago (2016-10-03 20:45:06 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-03 20:57:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389993002/1
4 years, 2 months ago (2016-10-03 20:59:43 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:59:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/76383db4906c9357292846ace77566b34eb4...

Powered by Google App Engine
This is Rietveld 408576698