tests/SurfaceTest.cpp - Issue 2389983002: Refactored SkColorSpace and added in a Lab PCS GM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SurfaceTest.cpp

Issue 2389983002: Refactored SkColorSpace and added in a Lab PCS GM (Closed)

Patch Set: multiplied the matrix for the temporary XYZTRC profile from an A2B0 profile code to match what woul… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SurfaceTest.cpp

diff --git a/tests/SurfaceTest.cpp b/tests/SurfaceTest.cpp

index 224e8c74cfc3ce1a03818b581799536db5ad2ead..96259f2136ba5ddb3a515e282a937bdcf838c584 100644

--- a/tests/SurfaceTest.cpp

+++ b/tests/SurfaceTest.cpp

@@ -7,7 +7,7 @@

#include <functional>

#include "SkCanvas.h"

-#include "SkColorSpace_Base.h"

+#include "SkColorSpace_XYZTRC.h"

#include "SkData.h"

#include "SkDevice.h"

#include "SkImage_Base.h"

@@ -921,7 +921,7 @@ static void test_surface_creation_and_snapshot_with_color_space(

auto srgbColorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGB_Named);

auto adobeColorSpace = SkColorSpace::NewNamed(SkColorSpace::kAdobeRGB_Named);

- SkMatrix44 srgbMatrix = as_CSB(srgbColorSpace)->toXYZD50();

+ const SkMatrix44& srgbMatrix = as_CSXYZ(srgbColorSpace)->toXYZD50();

const float oddGamma[] = { 2.4f, 2.4f, 2.4f };

auto oddColorSpace = SkColorSpace_Base::NewRGB(oddGamma, srgbMatrix);

auto linearColorSpace = SkColorSpace::NewNamed(SkColorSpace::kSRGBLinear_Named);