tests/CodecTest.cpp - Issue 2389983002: Refactored SkColorSpace and added in a Lab PCS GM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/CodecTest.cpp

Issue 2389983002: Refactored SkColorSpace and added in a Lab PCS GM (Closed)

Patch Set: migrated call from SkColorSpace_Base::makeLinearGamma() to SkColorSpace_XYZ::makeLinearGamma() Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/CodecTest.cpp

diff --git a/tests/CodecTest.cpp b/tests/CodecTest.cpp

index a6058a9c35f75c5481ec5b49f0111aea0046ce00..45455b440577228e3a259de6401481f79c9af683 100644

--- a/tests/CodecTest.cpp

+++ b/tests/CodecTest.cpp

@@ -10,7 +10,7 @@

#include "SkBitmap.h"

#include "SkCodec.h"

#include "SkCodecImageGenerator.h"

-#include "SkColorSpace_Base.h"

+#include "SkColorSpace_XYZ.h"

#include "SkData.h"

#include "SkImageEncoder.h"

#include "SkFrontBufferedStream.h"

@@ -1192,7 +1192,9 @@ static void test_conversion_possible(skiatest::Reporter* r, const char* path,

REPORTER_ASSERT(r, SkCodec::kUnimplemented == result);

}

- infoF16 = infoF16.makeColorSpace(as_CSB(infoF16.colorSpace())->makeLinearGamma());

+ SkASSERT(SkColorSpace_Base::Type::kXYZ == as_CSB(infoF16.colorSpace())->type());

+ SkColorSpace_XYZ* csXYZ = static_cast<SkColorSpace_XYZ*>(infoF16.colorSpace());

+ infoF16 = infoF16.makeColorSpace(csXYZ->makeLinearGamma());

result = codec->getPixels(infoF16, bm.getPixels(), bm.rowBytes());

REPORTER_ASSERT(r, SkCodec::kSuccess == result);

result = codec->startScanlineDecode(infoF16);

« no previous file with comments | « src/gpu/GrColorSpaceXform.cpp ('k') | tests/ColorSpaceTest.cpp » ('j') | no next file with comments »