Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: src/gpu/GrColorSpaceXform.cpp

Issue 2389983002: Refactored SkColorSpace and added in a Lab PCS GM (Closed)
Patch Set: Responding to comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/GrColorSpaceXform.cpp
diff --git a/src/gpu/GrColorSpaceXform.cpp b/src/gpu/GrColorSpaceXform.cpp
index d2270fafdd4a2458b4f8a1721be0a4f41f5adf26..b5404a6fb66c6a54462f7a90a80aab4fb684c18d 100644
--- a/src/gpu/GrColorSpaceXform.cpp
+++ b/src/gpu/GrColorSpaceXform.cpp
@@ -50,7 +50,11 @@ sk_sp<GrColorSpaceXform> GrColorSpaceXform::Make(SkColorSpace* src, SkColorSpace
}
SkMatrix44 srcToDst(SkMatrix44::kUninitialized_Constructor);
- srcToDst.setConcat(as_CSB(dst)->fromXYZD50(), as_CSB(src)->toXYZD50());
+ const SkMatrix44* toXYZD50 = as_CSB(src)->toXYZD50();
msarett 2016/10/14 21:31:40 Asserts in test code are good. Asserts in *unreac
raftias 2016/10/17 15:28:02 Done. Everywhere else seems to either be test code
+ SkASSERT(toXYZD50);
+ const SkMatrix44* fromXYZD50 = as_CSB(dst)->fromXYZD50();
+ SkASSERT(fromXYZD50);
+ srcToDst.setConcat(*fromXYZD50, *toXYZD50);
if (matrix_is_almost_identity(srcToDst)) {
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698