Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(268)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: resources/icc_profiles/srgb_lab_pcs.icc
Issue
2389983002
:
Refactored SkColorSpace and added in a Lab PCS GM (Closed)
Patch Set: Responding to comments
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
bench/ColorCodecBench.cpp
dm/DMSrcSink.cpp
gm/gamut.cpp
gm/labpcsdemo.cpp
gyp/core.gypi
resources/icc_profiles/srgb_lab_pcs.icc
samplecode/SampleApp.cpp
src/core/SkColorSpace.cpp
src/core/SkColorSpaceXform.cpp
src/core/SkColorSpaceXform_Base.h
src/core/SkColorSpace_A2B0.h
src/core/SkColorSpace_A2B0.cpp
src/core/SkColorSpace_Base.h
src/core/SkColorSpace_ICC.cpp
src/core/SkColorSpace_XYZTRC.h
src/core/SkColorSpace_XYZTRC.cpp
src/gpu/GrColorSpaceXform.cpp
tests/CodecTest.cpp
tests/ColorSpaceTest.cpp
tests/ColorSpaceXformTest.cpp
tests/SurfaceTest.cpp
tests/TestConfigParsing.cpp
tools/flags/SkCommonFlagsConfig.cpp
tools/visualize_color_gamut.cpp
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« gyp/core.gypi
('k') |
samplecode/SampleApp.cpp »
('j') |
src/core/SkColorSpace.cpp »
('J')
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« no previous file with comments
|
« gyp/core.gypi
('k') |
samplecode/SampleApp.cpp »
('j') |
src/core/SkColorSpace.cpp »
('J')
Issue 2389983002: Refactored SkColorSpace and added in a Lab PCS GM (Closed)
Created 4 years, 2 months ago by raftias
Modified 4 years, 2 months ago
Reviewers: msarett, Brian Osman, reed1, mtklein
Base URL:
Comments: 115
This is Rietveld
408576698
Chromium Code Reviews
Issue 2389983002:
Refactored SkColorSpace and added in a Lab PCS GM (Closed)
