Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2389973004: reflow comments in platform/{network,peerconnection} (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in platform/{network,peerconnection} BUG=563793 Committed: https://crrev.com/2ca4e6adc710c7ca833a91abf1eac7cc10c20034 Cr-Commit-Position: refs/heads/master@{#422606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -62 lines) Patch
M third_party/WebKit/Source/platform/network/EncodedFormDataTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/FormDataEncoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/FormDataEncoder.cpp View 4 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPHeaderMap.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 8 chunks +24 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/network/LinkHeader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ParsedContentType.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceError.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceLoadTiming.h View 1 chunk +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceRequest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 4 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.cpp View 4 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/network/WebSocketHandshakeRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
4 years, 2 months ago (2016-10-03 20:36:33 UTC) #4
pdr.
On 2016/10/03 at 20:36:33, thakis wrote: > LGTM
4 years, 2 months ago (2016-10-03 20:49:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389973004/1
4 years, 2 months ago (2016-10-03 20:52:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 23:55:24 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 23:58:06 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ca4e6adc710c7ca833a91abf1eac7cc10c20034
Cr-Commit-Position: refs/heads/master@{#422606}

Powered by Google App Engine
This is Rietveld 408576698