Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2389973003: Avoid unneeded paint copies in SkDraw::drawBitmap (Closed)

Created:
4 years, 2 months ago by f(malita)
Modified:
4 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid unneeded paint copies in SkDraw::drawBitmap Use SkTCopyOnFirstWrite to only copy when needed. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389973003 Committed: https://skia.googlesource.com/skia/+/f85d2a4fa1b71e6ee28518431e2a34df5683bc81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/core/SkDraw.cpp View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
f(malita)
4 years, 2 months ago (2016-10-03 20:05:18 UTC) #2
reed1
lgtm
4 years, 2 months ago (2016-10-03 20:14:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389973003/1
4 years, 2 months ago (2016-10-03 20:25:29 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:47:01 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f85d2a4fa1b71e6ee28518431e2a34df5683bc81

Powered by Google App Engine
This is Rietveld 408576698