Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2389963007: Revert of [heap] Simplify marking of JSFunction and SFI (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Simplify marking of JSFunction and SFI (patchset #3 id:40001 of https://codereview.chromium.org/2389183002/ ) Reason for revert: Broke GCStress. Original issue's description: > [heap] Simplify marking of JSFunction and SFI > > BUG=chromium:651828 > > Committed: https://crrev.com/4d45ed4597d537cf9624cb6683dc4bd646d11242 > Cr-Commit-Position: refs/heads/master@{#39975} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651828 Committed: https://crrev.com/5295d7a463cbcc78a4b694a7fb84af8e8e400303 Cr-Commit-Position: refs/heads/master@{#39983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M src/heap/objects-visiting.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +28 lines, -12 lines 0 comments Download
M src/objects.h View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
epertoso
Created Revert of [heap] Simplify marking of JSFunction and SFI
4 years, 2 months ago (2016-10-05 10:22:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389963007/1
4 years, 2 months ago (2016-10-05 10:22:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 10:22:33 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5295d7a463cbcc78a4b694a7fb84af8e8e400303 Cr-Commit-Position: refs/heads/master@{#39983}
4 years, 2 months ago (2016-10-05 10:22:46 UTC) #6
Michael Lippautz
4 years, 2 months ago (2016-10-05 12:27:38 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2390373004/ by mlippautz@chromium.org.

The reason for reverting is: Wrong culprit as this was already broken before..

Powered by Google App Engine
This is Rietveld 408576698