Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2389963002: Move setMediaPlaybackRequiresUserGesture to the cross-origin frame. (Closed)

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
4 years, 2 months ago
CC:
blink-reviews, chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move setMediaPlaybackRequiresUserGesture to the cross-origin frame. Before this CL the http/tests/webaudio/autoplay-crossorigin.html layout test would fail if the main frame and the cross-origin frame are in different renderer processes. After this CL, the internal settings are set from the same frame that hosts AudioContext object - this ensures that setting the settings and getting the settings happens from the same renderer process (and consequently ensures that the test passes both with and without --site-per-process flag). BUG=652366 Committed: https://crrev.com/f33a8c06201766c37344768aaf99846f78857ff3 Cr-Commit-Position: refs/heads/master@{#422746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/webaudio/autoplay-crossorigin.html View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/webaudio/resources/autoplay-crossorigin-iframe.html View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Łukasz Anforowicz
Alex, can you take a look please? I think simply moving where setMediaPlaybackRequiresUserGesture gets called ...
4 years, 2 months ago (2016-10-03 20:11:28 UTC) #4
alexmos
LGTM. Thanks for proactively fixing the test! I agree that it makes sense to tweak ...
4 years, 2 months ago (2016-10-03 20:23:12 UTC) #5
Łukasz Anforowicz
mlamouri@, can you also take a quick look please (since you've authored the test :-).
4 years, 2 months ago (2016-10-03 20:39:35 UTC) #8
mlamouri (slow - plz ping)
lgtm
4 years, 2 months ago (2016-10-04 10:45:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389963002/1
4 years, 2 months ago (2016-10-04 10:45:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 10:50:38 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 10:51:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f33a8c06201766c37344768aaf99846f78857ff3
Cr-Commit-Position: refs/heads/master@{#422746}

Powered by Google App Engine
This is Rietveld 408576698