Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2389913002: Use paginationStrut() instead of paginationStrutForRow() (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use paginationStrut() instead of paginationStrutForRow() There's no change in behaviour. Now that we setPaginationStrut() on the row, we don't need to call paginationStrutForRow() outside of layout anymore. BUG=642814 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/1c81ee4bbd257cb08f4aa603abece114d855a18e Cr-Commit-Position: refs/heads/master@{#422858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
rhogan
4 years, 2 months ago (2016-10-03 18:34:41 UTC) #4
rhogan
4 years, 2 months ago (2016-10-03 18:34:52 UTC) #5
mstensho (USE GERRIT)
lgtm
4 years, 2 months ago (2016-10-03 18:37:28 UTC) #7
mstensho (USE GERRIT)
On 2016/10/03 18:37:28, mstensho wrote: > lgtm Wait! We need a test for this, right?
4 years, 2 months ago (2016-10-03 20:21:00 UTC) #10
rhogan
On 2016/10/03 at 20:21:00, mstensho wrote: > On 2016/10/03 18:37:28, mstensho wrote: > > lgtm ...
4 years, 2 months ago (2016-10-03 20:58:18 UTC) #11
mstensho (USE GERRIT)
On 2016/10/03 20:58:18, rhogan wrote: > On 2016/10/03 at 20:21:00, mstensho wrote: > > On ...
4 years, 2 months ago (2016-10-03 21:05:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389913002/1
4 years, 2 months ago (2016-10-04 17:58:27 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 18:07:15 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:10:03 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c81ee4bbd257cb08f4aa603abece114d855a18e
Cr-Commit-Position: refs/heads/master@{#422858}

Powered by Google App Engine
This is Rietveld 408576698