Benchmark tools: Android memtrack_helper meaningful errors.

Benchmark tools: Android memtrack_helper meaningful errors.

If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833
Committed: https://crrev.com/e6d5e13c45d66ed786adbb70c070b6027434afb1
Cr-Commit-Position: refs/heads/master@{#423531}

[kraynov, 2016-10-04 18:15:22]

kraynov@chromium.org changed reviewers:
+ primiano@chromium.org

[kraynov, 2016-10-04 18:15:23]

PTAL

[kraynov, 2016-10-04 18:16:08]

Description was changed from

==========
Benchmark tools: Android memtrack_helper meaningful errors.

If memcheck module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833
==========

to

==========
Benchmark tools: Android memtrack_helper meaningful errors.

If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833
==========

[Primiano Tucci (use gerrit), 2016-10-06 13:15:41]

LGTM thanks

https://codereview.chromium.org/2389883004/diff/1/tools/android/memtrack_help...
File tools/android/memtrack_helper/BUILD.gn (right):

https://codereview.chromium.org/2389883004/diff/1/tools/android/memtrack_help...
tools/android/memtrack_helper/BUILD.gn:6: # the final binary will not require
anything more than libc and libdl.
update this comment with liblog

https://codereview.chromium.org/2389883004/diff/1/tools/android/memtrack_help...
File tools/android/memtrack_helper/memtrack_helper.c (right):

https://codereview.chromium.org/2389883004/diff/1/tools/android/memtrack_help...
tools/android/memtrack_helper/memtrack_helper.c:215: if (res == -ENOENT) {
I was about to say that this looks wrong and usually the pattern is that res !=
0 and ENOENT is in "errno". But then I checked the sources and, sigh, you are
right. Consistency, yay.

[kraynov, 2016-10-06 13:28:07]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 13:28:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 14:40:48]

Dry run: This issue passed the CQ dry run.

[kraynov, 2016-10-06 14:41:08]

The CQ bit was checked by kraynov@chromium.org

[kraynov, 2016-10-06 14:41:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2389883004/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2016-10-06 14:41:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:49:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 14:49:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2016-10-06 14:54:28]

On 2016/10/06 14:49:41, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

rs lgtm

[kraynov, 2016-10-06 14:55:12]

The CQ bit was checked by kraynov@chromium.org

[commit-bot: I haz the power, 2016-10-06 14:55:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 14:59:58]

Description was changed from

==========
Benchmark tools: Android memtrack_helper meaningful errors.

If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833
==========

to

==========
Benchmark tools: Android memtrack_helper meaningful errors.

If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833
==========

[commit-bot: I haz the power, 2016-10-06 14:59:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 15:02:00]

Description was changed from

==========
Benchmark tools: Android memtrack_helper meaningful errors.

If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833
==========

to

==========
Benchmark tools: Android memtrack_helper meaningful errors.

If memtrack module is not available via libhardware then
meaningful error message will be printed and filed to logcat.

BUG=651833

Committed: https://crrev.com/e6d5e13c45d66ed786adbb70c070b6027434afb1
Cr-Commit-Position: refs/heads/master@{#423531}
==========

[commit-bot: I haz the power, 2016-10-06 15:02:01]

Patchset 2 (id:??) landed as
https://crrev.com/e6d5e13c45d66ed786adbb70c070b6027434afb1
Cr-Commit-Position: refs/heads/master@{#423531}